Fix Select.attachedTo #4458
Merged
Fix Select.attachedTo #4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would always fail to find anything.
jackkoenig
commented
Oct 10, 2024
| @@ -392,7 +392,7 @@ object Select { | |||
| .block | |||
| .getCommands() | |||
| ) { | |||
| case Attach(_, seq) if seq.contains(signal) => seq | |||
| case Attach(_, seq) if seq.contains(Node(signal)) => seq | |||
There was a problem hiding this comment.
The type of seq is Seq[Node] while signal is Data and obviously Data can never equal Node.
azidar
approved these changes
Oct 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Previously it would always fail to find anything. (cherry picked from commit 1aa41cd) # Conflicts: # src/main/scala/chisel3/aop/Select.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Previously it would always fail to find anything. (cherry picked from commit 1aa41cd) # Conflicts: # src/main/scala/chisel3/aop/Select.scala
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Previously it would always fail to find anything. (cherry picked from commit 1aa41cd) # Conflicts: # src/main/scala/chisel3/aop/Select.scala
This was referenced Oct 10, 2024
debs-sifive
pushed a commit
that referenced
this pull request
Oct 15, 2024
Previously it would always fail to find anything.
chiselbot
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Fix Select.attachedTo (#4458) Previously it would always fail to find anything. (cherry picked from commit 1aa41cd) # Conflicts: # src/main/scala/chisel3/aop/Select.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would always fail to find anything.
Working on the Mill build, I was lazy in setting up scalacOptions and applied
-Xlint:infer-anyto everything which caught this. Unfortuantely,Iterable.containsis not type safe but if you screw up the type, this lint will catch it inferringAny(orObject).Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.