Fix Boring.rwTap on instance ports (backport #4451) #4452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Boring.rwTap on instance ports Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate. Given FIRRTL now supports this, we can improve this API. Additionally, added a few more D/I + BoringUtils tests * Added test of rwTap on RWProbe * Testing tap of instance probe port (cherry picked from commit 3bbf860) # Conflicts: # src/main/scala/chisel3/util/experimental/BoringUtils.scala # src/test/scala/chiselTests/BoringUtilsTapSpec.scala
|
Cherry-pick of 3bbf860 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate.
Given FIRRTL now supports this, we can improve this API.
Additionally, added a few more D/I + BoringUtils tests
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
BoringUtils.rwTap can now works on a port of an
instance: Instance[..]Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.This is an automatic backport of pull request #4451 done by [Mergify](https://mergify.com).