Skip to content

Add Property expression for integer shift left #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add Property expression for integer shift left #4440

merged 1 commit into from
Oct 4, 2024

Conversation

maerhart
Copy link
Contributor

@maerhart maerhart commented Oct 4, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This adds an API for integer Property shift left.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 4, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maerhart / name: Martin Erhart (916832d)

@maerhart
Copy link
Contributor Author

maerhart commented Oct 4, 2024

I don't have write access to this repo and thus cannot add labels. Can someone please add the Feature label for me?

@seldridge seldridge added the Feature New feature, will be included in release notes label Oct 4, 2024
@jackkoenig jackkoenig added this to the 7.0 milestone Oct 4, 2024
jackkoenig
jackkoenig approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jackkoenig jackkoenig merged commit d9e4741 into chipsalliance:main Oct 4, 2024
17 of 18 checks passed
@maerhart maerhart deleted the maerhart-shl-property branch October 4, 2024 20:25
debs-sifive pushed a commit that referenced this pull request Oct 15, 2024
@maerhart @debs-sifive
Add Property expression for integer shift left (#4440)
d663d47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Feature New feature, will be included in release notes
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maerhart @jackkoenig @seldridge