Add skipIfAlreadyInBlock arg to layer.block #4327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an argument to `layer.block` which can be used to prevent a layer block from being created if the current builder state indicates that we are already inside a layer block. This API is intended to be used for library writers to provide a way to _maybe_ put an operation into a layer block. Specifically, this is intended for verification statements which should go into a default layer block (e.g., `Verification.Assert`), but should not do this if the Chisel user is already in another layer block. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
approved these changes
Aug 2, 2024
SpriteOvO
pushed a commit
that referenced
this pull request
Aug 6, 2024
Add an argument to `layer.block` which can be used to prevent a layer block from being created if the current builder state indicates that we are already inside a layer block. This API is intended to be used for library writers to provide a way to _maybe_ put an operation into a layer block. Specifically, this is intended for verification statements which should go into a default layer block (e.g., `Verification.Assert`), but should not do this if the Chisel user is already in another layer block. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an argument to
layer.blockwhich can be used to prevent a layer block from being created if the current builder state indicates that we are already inside a layer block. This API is intended to be used for library writers to provide a way to maybe put an operation into a layer block. Specifically, this is intended for verification statements which should go into a default layer block (e.g.,Verification.Assert), but should not do this if the Chisel user is already in another layer block.Release Notes
Add
skipIfAlreadyInLayerBlock: Booleanparameter tolayer.block. This is a more advanced API for a library writer to write an API where hardware is, by default, created in a layer block. However, if the user wraps the API in a layer block, then the layer block the API would create is elided.