Skip to content

Conversation

debs-sifive
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Adds Path.apply() function that support HasTargets, so that the paths of things that extend HasTarget, like SRAM, can be put into properties.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@debs-sifive debs-sifive added the Feature New feature, will be included in release notes label Aug 21, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) August 21, 2024 22:13
@jackkoenig jackkoenig merged commit d85b628 into main Aug 21, 2024
16 of 17 checks passed
@jackkoenig jackkoenig deleted the debs/hastarget-path branch August 21, 2024 22:27
@sequencer
Copy link
Member

i did same thing in #4298
I think the SRAM is only user? So I made it private. Maybe directly using Property can provide a better api?

sequencer added a commit that referenced this pull request Aug 27, 2024
jackkoenig added a commit that referenced this pull request Aug 27, 2024
* Revert "Add `Path.apply()` to support `HasTarget` (#4364)"

This reverts commit d85b628.

* Add SRAMDescription for describing SRAM metadata

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants