Add layer.elideBlocks API #4348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an API, `chisel3.layer.elideBlocks` that will cause any calls to create a layer block inside its thunk to _not_ be created. This is an advanced API intended to be used in situations where a library has to avoid additional layer block creation. This is specifically being added because we have an API, backed by an in-tree CIRCT transforms, which can create bound modules and does so _after_ layers are converted to modules. While this API is intended to be replaced with layers, initially it needs to have a way to prevent layers from being added to the design to prevent creation of a bind-under-bind in the output. I expect this API to be short lived... Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an API,
chisel3.layer.elideBlocksthat will cause any calls to create a layer block inside its thunk to not be created. This is an advanced API intended to be used in situations where a library has to avoid additional layer block creation.This is specifically being added because we have an API, backed by an in-tree CIRCT transforms, which can create bound modules and does so after layers are converted to modules. While this API is intended to be replaced with layers, initially it needs to have a way to prevent layers from being added to the design to prevent creation of a bind-under-bind in the output.
I expect this API to be short lived...
Release Notes
Add
chisel3.layer.elideBlocksAPI that can be used to prevent the creation of additional layer blocks. This is an advanced, library writer's API that is not intended for general use.