Emit FIRRTL bulk connects even for "input" wires #4219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
reviewed
Jun 26, 2024
| val w1, w2 = Wire(new MyBundle) | ||
| w2 <> w1 | ||
| }) | ||
| chirrtl should include("connect w2, w1") |
There was a problem hiding this comment.
i never thought that <> was very sound for connecting two wires, so this is no worse than before 🤷♀️
There was a problem hiding this comment.
Until recently, I didn't know it even could work for two wires. As I mention in #4218, it does because of the special logic to sometimes emit FIRRTL bulk connects. So that work which was intended to be purely an optimization and not API visible actually extended the <> API in some funky ways.
This PR just makes it slightly more consistent in its funkiness 😇
mwachs5
approved these changes
Jul 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
(cherry picked from commit 0a3d157)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4218
One can question the need for this, as it's just making
<>not error in a few more cases. The main motivation is that #4205 causes some existing uses of<>that used to work no longer work. It's an unnecessary breakage that is fixed by this change.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.