Skip to content

[LTL] Add support for new sequence and property ops #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 6, 2024
Merged

[LTL] Add support for new sequence and property ops #4120

merged 14 commits into from
Jun 6, 2024

Conversation

dobios
Copy link
Member

@dobios dobios commented May 31, 2024 •
edited
Loading

This PR adds support for the ltl ops that were recently added to the ltl dialect in CIRCT:

  • Intersect
  • Repeat
  • GoToRepeat
  • NonConsecutiveRepeat
  • Until

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

  • [LTL] Add support for intersect, repeat, gotoRepeat, and nonConsecutiveRepeat ops.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@dobios
Copy link
Member Author

dobios commented May 31, 2024

The new ops should be included in the next release of firtool

@dobios dobios marked this pull request as ready for review June 5, 2024 19:17
@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Jun 5, 2024
@jackkoenig jackkoenig added this to the 7.0 milestone Jun 5, 2024
jackkoenig
jackkoenig approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but please see comments about intersect.

sequencer
sequencer reviewed Jun 6, 2024
View reviewed changes
@dobios dobios enabled auto-merge (squash) June 6, 2024 01:28
@dobios dobios disabled auto-merge June 6, 2024 01:28
@dobios dobios enabled auto-merge (squash) June 6, 2024 01:30
@dobios dobios merged commit 6de9640 into chipsalliance:main Jun 6, 2024
@dobios dobios deleted the new-ltl-ops branch June 6, 2024 01:37
kivikakk pushed a commit to kivikakk/chisel that referenced this pull request Jun 6, 2024
@dobios @kivikakk
[LTL] Add support for new sequence and property ops (chipsalliance#4120)
37dc91d 
Add support for `until`, `intersect`, `repeat`, `non_consecutive_repeat`, and `goto_repeat` property operations from SVA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sequencer sequencer sequencer left review comments

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Feature New feature, will be included in release notes
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dobios @sequencer @jackkoenig