Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 30, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Now checkTypeEquivalence will check whether data have the same probe type modifier including writeability and color (layer).

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4064 done by [Mergify](https://mergify.com).

* type equivalence includes probe
* Add type equivalence checks for Probes, including writeability and color.

(cherry picked from commit 62f8a05)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label May 30, 2024
@github-actions github-actions bot added API Modification Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. labels May 30, 2024
@chiselbot chiselbot merged commit f554181 into 6.x May 30, 2024
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4064 branch May 30, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Modification Backport Automated backport, please consider for minor release Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants