Skip to content

[ci] Stop copying body over to backports in backport-fixup #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

[ci] Stop copying body over to backports in backport-fixup #4005

merged 1 commit into from
Apr 17, 2024

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Apr 17, 2024 •
edited
Loading

This action formerly copied over the PR body but it seems Mergify does that itself now.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label Apr 17, 2024
@dtzSiFive
Copy link
Member

Pick a merge strategy (squash?)?

dtzSiFive
dtzSiFive approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked that recent mergify backports have duplicated body.

@jackkoenig
Copy link
Contributor Author

Pick a merge strategy (squash?)?

Whoops, I deleted the comment but not the other line lol, thanks!

@jackkoenig jackkoenig merged commit 81095f0 into main Apr 17, 2024
@jackkoenig jackkoenig deleted the jackkoenig/fix-backport-fixup branch April 17, 2024 22:29
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
@jackkoenig @SpriteOvO
[ci] Stop copying body over to backports in backport-fixup (#4005)
38d52db
@jackkoenig jackkoenig added this to the 5.x milestone May 1, 2024
@mergify mergify bot added the Backported This PR has been backported label May 1, 2024
mergify bot pushed a commit that referenced this pull request May 1, 2024
@jackkoenig @mergify
[ci] Stop copying body over to backports in backport-fixup (#4005)
4062f2f 
(cherry picked from commit 81095f0)
mergify bot pushed a commit that referenced this pull request May 1, 2024
@jackkoenig @mergify
[ci] Stop copying body over to backports in backport-fixup (#4005)
b9f29b3 
(cherry picked from commit 81095f0)
This was referenced May 1, 2024
Merged
Merged
chiselbot pushed a commit that referenced this pull request May 1, 2024
@mergify @jackkoenig
[ci] Stop copying body over to backports in backport-fixup (#4005) (#…
8f551e4 
…4042)

(cherry picked from commit 81095f0)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request May 1, 2024
@mergify @jackkoenig
[ci] Stop copying body over to backports in backport-fixup (#4005) (#…
39b6a53 
…4043)

(cherry picked from commit 81095f0)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@jackkoenig
Copy link
Contributor Author

@Mergifyio backport 3.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 1, 2024 •
edited
Loading

backport 3.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 1, 2024
@jackkoenig @mergify
[ci] Stop copying body over to backports in backport-fixup (#4005)
3635121 
(cherry picked from commit 81095f0)
@mergify mergify bot mentioned this pull request May 1, 2024
Merged
14 tasks
jackkoenig added a commit that referenced this pull request May 2, 2024
@jackkoenig
[ci] Stop copying body over to backports in backport-fixup (#4005)
e25d1f3 
(cherry picked from commit 81095f0)
chiselbot pushed a commit that referenced this pull request May 2, 2024
@mergify @jackkoenig
[ci] Stop copying body over to backports in backport-fixup (#4005) (#…
e5d3734 
…4048)

(cherry picked from commit 81095f0)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @dtzSiFive