Fix boring tap of non-passive source from parent. #4083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expected result is fully aligned, which is what happens when reading from a probe. When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands. For lack of a way to do, e.g., `:#=` here, use `read(probe(x))` to get the fully aligned result that's expected and bored down to the child. This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting. Fixes #3557.
jackkoenig
reviewed
May 23, 2024
jackkoenig
approved these changes
May 24, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
Expected result is fully aligned, which is what happens when reading from a probe. When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands. For lack of a way to do, e.g., `:#=` here, use `read(probe(x))` to get the fully aligned result that's expected and bored down to the child. This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting. Fixes #3557. (cherry picked from commit 0dbedc3) # Conflicts: # core/src/main/scala/chisel3/RawModule.scala
14 tasks
jackkoenig
pushed a commit
that referenced
this pull request
May 24, 2024
Expected result is fully aligned, which is what happens when reading from a probe. When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands. For lack of a way to do, e.g., `:#=` here, use `read(probe(x))` to get the fully aligned result that's expected and bored down to the child. This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting. Fixes #3557. (cherry picked from commit 0dbedc3) # Conflicts: # core/src/main/scala/chisel3/RawModule.scala
chiselbot
pushed a commit
that referenced
this pull request
May 27, 2024
…4096) * Fix boring tap of non-passive source from parent. (#4083) Expected result is fully aligned, which is what happens when reading from a probe. When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands. For lack of a way to do, e.g., `:#=` here, use `read(probe(x))` to get the fully aligned result that's expected and bored down to the child. This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting. Fixes #3557. (cherry picked from commit 0dbedc3) # Conflicts: # core/src/main/scala/chisel3/RawModule.scala * Resolve backport conflicts --------- Co-authored-by: Will Dietz <will.dietz@sifive.com> Co-authored-by: Jack Koenig <koenig@sifive.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected result is fully aligned, which is what happens when reading from a probe.
When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands.
For lack of a way to do, e.g.,
:#=here,use
read(probe(x))to get the fully aligned result that's expected and bored down to the child.This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting.
Fixes #3557.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Fix tapping mix-alignment signal from parent.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.