Skip to content

Fix literal handling for views of empty Aggregates #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2024
Merged

Fix literal handling for views of empty Aggregates #4071

merged 2 commits into from
May 20, 2024

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented May 17, 2024 •
edited
Loading

This requires #4070 for the tests to pass

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Previously, a view of an empty aggregate would incorrectly always have a litValue of 0.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Fix literal handling for views of empty Aggregates
c1814bb 
Previously, a view of an empty Record or Vec would always have a
litValue of 0.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label May 17, 2024
@jackkoenig jackkoenig added this to the 5.x milestone May 17, 2024
@jackkoenig jackkoenig merged commit 11c3f51 into main May 20, 2024
@jackkoenig jackkoenig deleted the fix-literals-for-views-of-empty-aggregates branch May 20, 2024 17:54
@mergify mergify bot added the Backported This PR has been backported label May 20, 2024
mergify bot pushed a commit that referenced this pull request May 20, 2024
@jackkoenig @mergify
Fix literal handling for views of empty Aggregates (#4071)
e9532c9 
Previously, a view of an empty Record or Vec would always have a
litValue of 0.

(cherry picked from commit 11c3f51)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request May 20, 2024
@jackkoenig @mergify
Fix literal handling for views of empty Aggregates (#4071)
b233ae4 
Previously, a view of an empty Record or Vec would always have a
litValue of 0.

(cherry picked from commit 11c3f51)
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request May 20, 2024
@mergify @jackkoenig
Fix literal handling for views of empty Aggregates (#4071) (#4075)
08a7293 
Previously, a view of an empty Record or Vec would always have a
litValue of 0.

(cherry picked from commit 11c3f51)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request May 20, 2024
@mergify @jackkoenig
Fix literal handling for views of empty Aggregates (backport #4071) (#…
7f1ab3c 
…4074)

* Fix literal handling for views of empty Aggregates (#4071)

Previously, a view of an empty Record or Vec would always have a
litValue of 0.

(cherry picked from commit 11c3f51)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala

* Fixup backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @mwachs5