Skip to content

Fix === for abstract Reset types #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix === for abstract Reset types #3979

merged 1 commit into from
Apr 9, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Previously, the function would infinitely recurse resulting in a stack overflow.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Fix === for abstract Reset types
a286b78 
Previously, the function would infinitely recurse resulting in a stack
overflow.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Apr 9, 2024
@jackkoenig jackkoenig added this to the 3.6.x milestone Apr 9, 2024
@jackkoenig jackkoenig requested a review from seldridge April 9, 2024 21:34
seldridge
seldridge approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig enabled auto-merge (squash) April 9, 2024 21:40
@jackkoenig jackkoenig merged commit ea2d103 into main Apr 9, 2024
@jackkoenig jackkoenig deleted the fix-dataequality-for-abstract-reset branch April 9, 2024 21:49
@mergify mergify bot added the Backported This PR has been backported label Apr 9, 2024
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
@jackkoenig @mergify
Fix === for abstract Reset types (#3979)
4dd53da 
Previously, the function would infinitely recurse resulting in a stack
overflow.

(cherry picked from commit ea2d103)

# Conflicts:
#	core/src/main/scala/chisel3/Data.scala
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
@jackkoenig @mergify
Fix === for abstract Reset types (#3979)
31a9d13 
Previously, the function would infinitely recurse resulting in a stack
overflow.

(cherry picked from commit ea2d103)
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
@jackkoenig @mergify
Fix === for abstract Reset types (#3979)
6ed5c4f 
Previously, the function would infinitely recurse resulting in a stack
overflow.

(cherry picked from commit ea2d103)
This was referenced Apr 9, 2024
Merged
Merged
Merged
chiselbot pushed a commit that referenced this pull request Apr 9, 2024
@mergify @jackkoenig
Fix === for abstract Reset types (#3979) (#3981)
daede76 
Previously, the function would infinitely recurse resulting in a stack
overflow.

(cherry picked from commit ea2d103)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Apr 9, 2024
@mergify @jackkoenig
Fix === for abstract Reset types (#3979) (#3982)
5587c50 
Previously, the function would infinitely recurse resulting in a stack
overflow.

(cherry picked from commit ea2d103)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Apr 9, 2024
@mergify @jackkoenig
Fix === for abstract Reset types (backport #3979) (#3980)
3926710 
* Fix === for abstract Reset types (#3979)

Previously, the function would infinitely recurse resulting in a stack
overflow.

(cherry picked from commit ea2d103)

# Conflicts:
#	core/src/main/scala/chisel3/Data.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
@jackkoenig @SpriteOvO
Fix === for abstract Reset types (#3979)
3798136 
Previously, the function would infinitely recurse resulting in a stack
overflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge