Skip to content

Conversation

SpriteOvO
Copy link
Member

@SpriteOvO SpriteOvO commented Feb 24, 2024

Some unexpected CI failures occurred in PR #3842, logs https://github.com/chipsalliance/chisel/actions/runs/8029630555

  • Updates the jextract download URL, the previous one is no longer accessible.

@SpriteOvO SpriteOvO changed the base branch from main to ci/ci-circt-nightly February 24, 2024 09:48
@SpriteOvO SpriteOvO force-pushed the fix-ci branch 5 times, most recently from 33e610c to 4d55ef1 Compare February 24, 2024 10:18
@dtzSiFive
Copy link
Member

LGTM, thanks!

@dtzSiFive
Copy link
Member

Can/should this target "main" since CI is broken everywhere with the now-dead jextract URL?

@SpriteOvO SpriteOvO changed the base branch from ci/ci-circt-nightly to main February 26, 2024 14:19
@SpriteOvO SpriteOvO changed the title [WIP] Fix CI [ci] Update jextract download URL Feb 26, 2024
@SpriteOvO SpriteOvO changed the title [ci] Update jextract download URL [ci] Update jextract download URL Feb 26, 2024
@SpriteOvO SpriteOvO marked this pull request as ready for review February 26, 2024 14:21
@SpriteOvO
Copy link
Member Author

@dtzSiFive Of course! And I see some tests that caused nightly CI to fail are fixed in #3869, nice work!

@sequencer sequencer added the Internal Internal change, does not affect users, will be included in release notes label Feb 26, 2024
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Feb 26, 2024
@chiselbot chiselbot merged commit a8e0560 into chipsalliance:main Feb 26, 2024
@SpriteOvO SpriteOvO deleted the fix-ci branch February 26, 2024 14:37
sequencer pushed a commit that referenced this pull request Feb 28, 2024
jackkoenig pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal change, does not affect users, will be included in release notes Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants