Skip to content

Pass FIRRTL annotations into CIRCTConverter #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

Pass FIRRTL annotations into CIRCTConverter #3842

merged 2 commits into from
Feb 29, 2024

Conversation

SpriteOvO
Copy link
Member

@SpriteOvO SpriteOvO commented Feb 21, 2024 •
edited
Loading

Upstream PR: llvm/circt#6730

Still working in progress.

@SpriteOvO SpriteOvO force-pushed the binder-anno branch 9 times, most recently from 8df1934 to d4167db Compare February 21, 2024 15:25
sequencer
sequencer requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c37af1b is my fixup for your question.

@SpriteOvO SpriteOvO force-pushed the binder-anno branch 5 times, most recently from 4c91afb to e00b288 Compare February 21, 2024 18:34
@sequencer sequencer changed the base branch from main to ci/ci-circt-nightly February 21, 2024 18:36
@sequencer
Copy link
Member

LGTM, changed base to ci/ci-circt-nightly, T1 is successfully elaborated MLIR w/ this PR.

@sequencer sequencer mentioned this pull request Feb 21, 2024
Merged
@SpriteOvO SpriteOvO marked this pull request as ready for review February 21, 2024 18:52
sequencer
sequencer requested changes Feb 24, 2024
View reviewed changes
@SpriteOvO SpriteOvO mentioned this pull request Feb 24, 2024
Merged
@SpriteOvO SpriteOvO force-pushed the binder-anno branch 2 times, most recently from 055409a to 919a3a8 Compare February 28, 2024 07:51
@github-actions github-actions bot force-pushed the ci/ci-circt-nightly branch from 7ab5689 to c161fcc Compare February 28, 2024 11:04
@SpriteOvO SpriteOvO force-pushed the binder-anno branch 2 times, most recently from 4b7c9eb to 34d420e Compare February 29, 2024 13:50
@SpriteOvO SpriteOvO merged commit 4b3beec into chipsalliance:ci/ci-circt-nightly Feb 29, 2024
@SpriteOvO SpriteOvO deleted the binder-anno branch February 29, 2024 14:10
@sequencer sequencer added Internal Internal change, does not affect users, will be included in release notes Panama Related to Panama Binding Framework labels Feb 29, 2024
@sequencer
Copy link
Member

sequencer commented Feb 29, 2024 •
edited
Loading

@SpriteOvO Please use 'Please Merge' label to ask bot merge it. A label is also required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sequencer sequencer sequencer requested changes

Assignees
No one assigned
Labels
Internal Internal change, does not affect users, will be included in release notes Panama Related to Panama Binding Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpriteOvO @sequencer