Fix Reg() to properly handle clocks as rvalues
#3775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref.
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref. (cherry picked from commit 1c348c5) # Conflicts: # src/test/scala/chiselTests/ClockSpec.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref. (cherry picked from commit 1c348c5) # Conflicts: # src/test/scala/chiselTests/ClockSpec.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref. (cherry picked from commit 1c348c5)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Jan 30, 2024
Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref. (cherry picked from commit 1c348c5) Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot
pushed a commit
that referenced
this pull request
Jan 30, 2024
) * Fix Reg() to properly handle clocks as rvalues (#3775) Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref. (cherry picked from commit 1c348c5) # Conflicts: # src/test/scala/chiselTests/ClockSpec.scala * Resolve backport conflicts * fix test --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot
pushed a commit
that referenced
this pull request
Jan 30, 2024
) * Fix Reg() to properly handle clocks as rvalues (#3775) Previously, it was not calling .ref. It was thus not properly: 1. Checking that the clock is bound hardware 2. Checking that the clock is visible in the current scope 3. Reifying the clock if its a view Note that RegInit() was already correctly calling .ref. (cherry picked from commit 1c348c5) # Conflicts: # src/test/scala/chiselTests/ClockSpec.scala * Resolve backport conflicts * fix test --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not calling .ref. It was thus not properly:
Note that RegInit() was already correctly calling .ref.
h/t @nandor for noticing this, pretty crazy such a fundamental bug has been lingering without being noticed.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
DataView(includingFlatIO)Reg()Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.