Convert cloneType to an extension method #3771
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes much of the use of this.type in Chisel which is necessary to upgrade to Scala 3.
There is still
this.type
used for other purposes:I figure we can fix these in multiple IRs, this is the biggest one that is the most likely to cause breakages. While this is almost entirely source compatible, you may notice a few places I had to add
this.
in front of acloneType
. It will break any code where the user callscloneType
from within aBundle
orRecord
but leaves of the implicitthis.
. I'm not sure how big of an issue this is, we could potentially warn about it with the compiler plugin on 6.x.Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.