Skip to content

Fix DataMirror.internal.chiselTypeClone to preserve Scala type #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix DataMirror.internal.chiselTypeClone to preserve Scala type #3553

merged 1 commit into from
Sep 26, 2023

Conversation

jackkoenig
Copy link
Contributor

See chipsalliance/rocket-chip#3476

This has been a lingering issue, about time we fixed it.

I'm going to try backporting this but it may or may not be binary compatible.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 3.6.x milestone Sep 26, 2023
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Sep 26, 2023
@jackkoenig jackkoenig merged commit e6c07b3 into main Sep 26, 2023
@jackkoenig jackkoenig deleted the fix-chiseltypeclone branch September 26, 2023 20:20
@mergify mergify bot added the Backported This PR has been backported label Sep 26, 2023
@jackkoenig jackkoenig mentioned this pull request Sep 26, 2023
Draft
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
@jackkoenig @mergify
Fix DataMirror.internal.chiselTypeClone to preserve Scala type (#3553)
6c5013b 
(cherry picked from commit e6c07b3)
@mergify mergify bot mentioned this pull request Sep 26, 2023
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
@jackkoenig @mergify
Fix DataMirror.internal.chiselTypeClone to preserve Scala type (#3553)
c4ae8ba 
(cherry picked from commit e6c07b3)
@mergify mergify bot mentioned this pull request Sep 26, 2023
Merged
14 tasks
mergify bot added a commit that referenced this pull request Sep 26, 2023
@mergify @jackkoenig
Fix DataMirror.internal.chiselTypeClone to preserve Scala type (#3553) (
d7630dc 
#3555)

(cherry picked from commit e6c07b3)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Sep 26, 2023
@mergify @jackkoenig
Fix DataMirror.internal.chiselTypeClone to preserve Scala type (#3553) (
3a31a03 
#3554)

(cherry picked from commit e6c07b3)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge