Skip to content

Add messages to require statements in Math (backport #3385) #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add messages to require statements in Math (backport #3385) #3387

merged 1 commit into from
Jun 27, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 27, 2023 •
edited by github-actions bot
Loading

This is an automatic backport of pull request #3385 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Original PR Body

  • log2 functions
  • unsignedBitLength

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

(The below might look weird but it'll make the release notes generation work better)

Release Notes

  • log2 functions
    • unsignedBitLength

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig @mergify
Add messages to require statements in Math (#3385)
123e214 
* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jun 27, 2023
@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Jun 27, 2023
@mergify mergify bot merged commit 9536927 into 3.6.x Jun 27, 2023
@mergify mergify bot deleted the mergify/bp/3.6.x/pr-3385 branch June 27, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jackkoenig