Skip to content

Add messages to require statements in Math #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add messages to require statements in Math #3385

merged 1 commit into from
Jun 27, 2023

Conversation

jackkoenig
Copy link
Contributor

  • log2 functions
  • unsignedBitLength

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

(The below might look weird but it'll make the release notes generation work better)

Release Notes

  • log2 functions
    • unsignedBitLength

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jun 27, 2023
@jackkoenig jackkoenig added this to the 3.5.x milestone Jun 27, 2023
@jackkoenig
Add messages to require statements in Math
baa412f 
* log2 functions
* unsignedBitLength
@jackkoenig jackkoenig merged commit 88fecfc into main Jun 27, 2023
@jackkoenig jackkoenig deleted the math-require-msg branch June 27, 2023 21:57
@mergify mergify bot added the Backported This PR has been backported label Jun 27, 2023
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
@jackkoenig @mergify
Add messages to require statements in Math (#3385)
389f9d8 
* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)

# Conflicts:
#	src/main/scala/chisel3/util/Math.scala
@mergify mergify bot mentioned this pull request Jun 27, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
@jackkoenig @mergify
Add messages to require statements in Math (#3385)
123e214 
* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
@jackkoenig @mergify
Add messages to require statements in Math (#3385)
afbc6bf 
* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)
This was referenced Jun 27, 2023
Merged
Merged
mergify bot added a commit that referenced this pull request Jun 27, 2023
@mergify @jackkoenig
Add messages to require statements in Math (#3385) (#3388)
ade513e 
* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Jun 27, 2023
@mergify @jackkoenig
Add messages to require statements in Math (#3385) (#3387)
9536927 
* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Jun 28, 2023
@mergify @jackkoenig
Add messages to require statements in Math (backport #3385) (#3386)
294f942 
* Add messages to require statements in Math (#3385)

* log2 functions
* unsignedBitLength

(cherry picked from commit 88fecfc)

# Conflicts:
#	src/main/scala/chisel3/util/Math.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
1 participant
@jackkoenig