Skip to content

[fix] typo fix: chosen port of arbiter is not onehot but UInt #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

[fix] typo fix: chosen port of arbiter is not onehot but UInt #3235

merged 1 commit into from
May 5, 2023

Conversation

SihaoLiu
Copy link
Contributor

@SihaoLiu SihaoLiu commented May 3, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Documentation or website-related

Desired Merge Strategy

Release Notes

Just a oneline fix to the comment of Arbiter chosen port

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@CLAassistant
Copy link

CLAassistant commented May 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jackkoenig jackkoenig added the Documentation Only changing documentation label May 5, 2023
@jackkoenig jackkoenig added this to the 3.6.x milestone May 5, 2023
@jackkoenig jackkoenig enabled auto-merge (squash) May 5, 2023 22:28
@jackkoenig jackkoenig merged commit b542b6a into chipsalliance:main May 5, 2023
@mergify mergify bot added the Backported This PR has been backported label May 5, 2023
mergify bot pushed a commit that referenced this pull request May 5, 2023
@SihaoLiu @mergify
[fix] typo fix: chosen port of arbiter is not onehot but plain UInt (#…
a987491 
…3235)

(cherry picked from commit b542b6a)
mergify bot pushed a commit that referenced this pull request May 5, 2023
@SihaoLiu @mergify
[fix] typo fix: chosen port of arbiter is not onehot but plain UInt (#…
ffe5989 
…3235)

(cherry picked from commit b542b6a)
This was referenced May 5, 2023
Merged
Merged
mergify bot added a commit that referenced this pull request May 5, 2023
@mergify @SihaoLiu
[fix] typo fix: chosen port of arbiter is not onehot but plain UInt (#…
bb7c787 
…3235) (#3260)

(cherry picked from commit b542b6a)

Co-authored-by: Sihao Liu <sihao@cs.ucla.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request May 6, 2023
@mergify @SihaoLiu
[fix] typo fix: chosen port of arbiter is not onehot but plain UInt (#…
643715b 
…3235) (#3261)

(cherry picked from commit b542b6a)

Co-authored-by: Sihao Liu <sihao@cs.ucla.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@sequencer sequencer mentioned this pull request Jun 20, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

+1 more reviewer

@ingallsj ingallsj ingallsj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Backported This PR has been backported Documentation Only changing documentation
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@SihaoLiu @CLAassistant @jackkoenig @ingallsj