Add Treadle to CI builds #1516
Merged
Add Treadle to CI builds #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change CI to build Treadle master from source. This fixes a bug where Treadle would be pulled from the latest snapshot (which would pull the latest FIRRTL snapshot). For bleeding edge PRs that rely on new FIRRTL features, using a FIRRTL snapshot may result in compilation failures. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
|
I added one commit, marked with |
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Fixes #1516 * Tighten up logic for "casted literal" checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CI to build Treadle master from source. This fixes a bug where
Treadle would be pulled from the latest snapshot (which would pull the
latest FIRRTL snapshot). For bleeding edge PRs that rely on new FIRRTL
features, using a FIRRTL snapshot may result in compilation failures.
Signed-off-by: Schuyler Eldridge schuyler.eldridge@ibm.com
Related issue: #1499 (comment)
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
None.