Co-authored-by: jackkoenig <jackkoenig@users.noreply.github.com>

…4042)

(cherry picked from commit 81095f0)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit e0daadd)

Co-authored-by: Jack Koenig <koenig@sifive.com>

)

* [chiselsim] Better fix for CIRCT 1.66- and 1.66+ (#3893)

Change the way ChiselSim moves files to track and not move files which may
be duplicated in both the default black box filelist and in the main
CIRCT-produced filelist.  Previously, this was working because a java.nio
exception was being ignored.  However, this may have been hiding bugs
where the filelist was actually pointing at a file that did not exist.

This commit also does some heavy cleanup of the code for moving files to only
use java.nio methods as opposed to relying on doing string manipulations of
paths.  The logic is intended to be the exact same as before.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 61df8bb)

* Help Scala 2.12 type inferencing with type annotations

---------

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Fix Nested Instantiate (#4018)

* minimal reproduce Nested Instantiate bug

* expose cache and elaborated defination to inner defination

* fix up

(cherry picked from commit 02b01e8)

# Conflicts:
#	core/src/main/scala/chisel3/experimental/hierarchy/core/Definition.scala
#	core/src/main/scala/chisel3/experimental/hierarchy/core/Instance.scala
#	core/src/main/scala/chisel3/internal/Builder.scala
#	src/main/scala/chisel3/aop/injecting/InjectingAspect.scala
#	src/main/scala/chisel3/stage/phases/Elaborate.scala

* Resolve backport conflicts

---------

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Add support for Vec literals of empty Vecs (#4070)

Also tweak Vec.Lit code to use cloneAsSuperType rather than implementing
its own version of the same concept.

(cherry picked from commit 86082b1)

# Conflicts:
#	src/test/scala/chiselTests/BundleLiteralSpec.scala
#	src/test/scala/chiselTests/VecLiteralSpec.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

…4074)

* Fix literal handling for views of empty Aggregates (#4071)

Previously, a view of an empty Record or Vec would always have a
litValue of 0.

(cherry picked from commit 11c3f51)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala

* Fixup backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

)

* [SVSim] Fixed non-firing AssertProperty in SVSim  (#4087)

(cherry picked from commit d3ab477)

# Conflicts:
#	src/test/scala/chiselTests/LTLSpec.scala
#	svsim/src/main/scala/verilator/Backend.scala

* Resolve backport conflicts

---------

Co-authored-by: Amelia Dobis <amelia.dobis@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Materialize wires for .ref of Aggregate views (#4080)

Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.

(cherry picked from commit 5af27e5)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

)

* Fix widths for literal values in Bundle literals (#4082)

* Fix widths for literal values in Bundle literals

Previously, the user-specified (or unspecified minimum width) of the
literal would be used in some operations like concatenation.

* Implicitly truncate too-wide literals in Bundle literals

This is to fix a bug in concatenation without breaking things relying on
implicit truncation. This will be a warning in newer versions of Chisel.

(cherry picked from commit 3939e57)

# Conflicts:
#	core/src/main/scala/chisel3/internal/firrtl/IR.scala
#	src/test/scala/chiselTests/ConnectableSpec.scala
#	src/test/scala/chiselTests/VecLiteralSpec.scala

* Waive false binary compatibility failure

Also move waivers from files to build.sbt.

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Fix 0 width signals chiselsim (#4100)

(cherry picked from commit 2f9faa2)

# Conflicts:
#	src/test/scala/chiselTests/simulator/SimulatorSpec.scala

* Resolve backport conflicts

---------

Co-authored-by: Raffaele Meloni <raffaele.meloni99@gmail.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Add test for FlatIO port ordering (#4113)

(cherry picked from commit c3c9979)

# Conflicts:
#	src/test/scala/chiselTests/experimental/FlatIOSpec.scala

* Added MatchesOrOmits

* Resolve backport conflicts

---------

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Adam Izraelevitz <azidar@gmail.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

…4116) (#4117)

* Bump versions of Github actions to versions using Node 20 (#4116)

Node 16 is deprecated and will eventually stop being supported.

(cherry picked from commit 99aa9f1)

# Conflicts:
#	.github/workflows/build-scala-cli-example.yml
#	.github/workflows/ci.yml
#	.github/workflows/install-jextract/action.yml
#	.github/workflows/scala-cli-example.yml
#	.github/workflows/test.yml

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 25f70bd)

Co-authored-by: qimingchu <cchuqiming@gmail.com>

* Add and use Mill wrapper script (#4119)

This saves developers from having to install a dependency. It also
allows us to drop an old Github Actions dependency that hasn't been
updated in 2 years. This is the standard practice for projects using
Mill on Github.

(cherry picked from commit 0f2efb5)

# Conflicts:
#	.github/workflows/test.yml
#	CONTRIBUTING.md
#	benchmark/src/main/scala/chisel3/benchmark/Benchmark.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>