Filter out languages that aren't RFC5646-shaped #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it's better to leave the first param blank.
So, should looks like this: const IntlDN = new Intl.DisplayNames(undefined, {
type: 'language',
});@illfygli is it possible for you to try this instead if it works? |
|
@cheeaun Good catch, that works and seems to give the same result! Updated the PR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try Phanpy, but only got a blank page, because
Intl.DisplayNamescan't handle some values that might appear innavigator.languages.As MDN says:
My config includes
*;q=0.5as the last value, which gives anavigator.languageslike['xx', 'xx', 'xx', 'xx', '*'].results in
RangeError: Incorrect locale information provided.So this proposed fix filters out any language tags that don't look like RFC 5646/BCP 47 format, which is what
Intl.DisplayNamesaccepts.It's not a full validator, but it does not exclude any valid tags.