-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
supplemental: add space between '//' and 'non-compiled' comments #17264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AmitKumarDeoghoria , did we remove jdk11 compilation? We supposed to substitute it with Jdk17 |
@mohitsatr , please investigate ci failure |
I don't understand what this error is about ?
the file |
Something is damaged in selection of files for compilation, please investigate shell job that doing it. |
1a3fe8f
to
37640a1
Compare
@romani do we handle Lines 21 to 22 in b48f7bf
on running
|
It is just another non-compiled source file. It is not compiled by Eclipse not a javac, so to avoid problems to Eclipse users, we put it non-compiled. Should continue to be there. Lets chat regexp to |
6e2c0e4
to
81e3cfd
Compare
weird, javac11 workflow in passing in my local. but it keeps a missed case everytime I push. |
81e3cfd
to
03b677c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot !!!!
@Zopsss , FYI I merged quickly as update was huge, to avoid conflicts with Jdk17 project activity. |
part of #17193