-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Issue #17168: Upgrade Pom Java version to 17 #17259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5f00a0b
to
0c1ce31
Compare
Update jdk version for error-prone in separate PR. Checker look like needs to updated together with pom, in same PR, you can apply all changes that Checker want to this PR, to keep it green. |
0c1ce31
to
3672a57
Compare
Please try fix what is possible at https://app.circleci.com/pipelines/github/checkstyle/checkstyle/34677/workflows/15a7b5a7-ae21-423c-a8e7-3fa7de9286b2/jobs/980685/artifacts We need CI to be green. |
Jdk11 https://checkstyle.semaphoreci.com/jobs/21741292-0cfc-4afe-8e01-5adf21d919d1#L403 ???
|
fa486c0
to
ec6664c
Compare
Will be solved after Semaphore jdk17 Upgrade PR : #17289 is merged. |
ec6664c
to
ce961ed
Compare
54f2484
to
258ec65
Compare
Ok, time to fix inspections. All inspections that are jdk17 only, should be moved to separate issue to be resolved separately, after migration to jdk17. In other words we need to disable them until issue . All others, should be fixed in separate PR, while we are in jdk11 |
258ec65
to
61a4190
Compare
61a4190
to
4dde366
Compare
Inspection still not happy |
Rebased in web UI |
More fixes for inspection is required https://app.circleci.com/pipelines/github/checkstyle/checkstyle/34754/workflows/7fdbe542-33b0-4283-b9af-d88aac2d5403/jobs/984333/artifacts |
And
|
cfe4de7
to
4209f60
Compare
@romani what should we do for : home/circleci/project/target/inspection-results/.descriptions.xml |
Nothing, it has no violations, it is just general description |
Rebased in web. I hope it is last time before merge |
@AmitKumarDeoghoria , if I rebased in web , you don't need to rebase and push again, it just wasted ci |
I am aware of that @romai CI was red, a patch was needed for checker suppression, so I merged the patch and then pushed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are on jdk17 !!!
thanks a lot for huge effort
part of : #17168