Skip to content

Issue #16630: fp when <p> is nested #16687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Issue #16630: fp when <p> is nested #16687

wants to merge 1 commit into from

Conversation

Aziz-755
Copy link
Contributor

@Aziz-755 Aziz-755 commented Mar 29, 2025 •
edited
Loading

Fixes: #16630
Fixed false-positive and some already existing tests.
The check was built on the assumption that a nested <p> tag means it is nested inside another <p> tag.
Now, no violation will be produced if a <p> tag is nested inside any other tag.
Diff Regression config: https://gist.githubusercontent.com/Aziz-755/be055e1bc5556b0a86f9bbbe2542247a/raw/f7e860c59ef49c966a88d724d359dc677fd16711/JavadocParagraphfp.xml

@Aziz-755
Copy link
Contributor Author

Github, generate report by config from InputJavadocParagraphIncorrect.java

@github-actions GitHub Actions
Copy link
Contributor

Report generation failed. Please check the logs for more details.

Link: https://github.com/checkstyle/checkstyle/actions/runs/14149036715

@Aziz-755
Copy link
Contributor Author

Aziz-755 commented Mar 29, 2025 •
edited
Loading

Github, generate report for InputJavadocParagraphIncorrect.java

@github-actions GitHub Actions
Copy link
Contributor

Failed to generate config from the specified file.
Please ensure the file exists and the path is correct.

Usage: 'GitHub, generate report by config from <file_path>'

Link: https://github.com/checkstyle/checkstyle/actions/runs/14149585776

@Aziz-755
Copy link
Contributor Author

Github, generate report

@github-actions GitHub Actions
Copy link
Contributor

Report generation failed on phase "make_report",
step "set upstream".
Link: https://github.com/checkstyle/checkstyle/actions/runs/14149894341

@Aziz-755
Copy link
Contributor Author

Aziz-755 commented Mar 29, 2025 •
edited
Loading

Github, generate report

1 similar comment
@Aziz-755
Copy link
Contributor Author

Github, generate report

@github-actions GitHub Actions
Copy link
Contributor

Report generation failed on phase "make_report",
step "set upstream".
Link: https://github.com/checkstyle/checkstyle/actions/runs/14150334535

romani
romani requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item:

.github/workflows/diff-report.yml Outdated
@@ -127,7 +127,7 @@ jobs:
MAIN_REPO_GIT_URL="https://github.com/checkstyle/checkstyle.git"
git remote add upstream "$MAIN_REPO_GIT_URL"
git fetch upstream
FORK_REPO_GIT_URL="https://github.com/$USER_LOGIN/checkstyle.git"
FORK_REPO_GIT_URL="https://github.com/$USER_LOGIN/checkstyle-fork.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@romani
Copy link
Member

romani commented Apr 1, 2025

Github, generate report for JavadocParagraph/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Report for JavadocParagraph/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9e9d8959ba69ab30f25be89e5141ecc6af9bcf67_2025125655/reports/diff/index.html

@Aziz-755
Copy link
Contributor Author

Aziz-755 commented Apr 1, 2025

Github, generate report for JavadocParagraph/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Failed to download or process the specified configuration(s).
Error details:

Please ensure you've used one of the following commands correctly:

@Aziz-755 Aziz-755 closed this by deleting the head repository Apr 1, 2025
@Aziz-755 Aziz-755 mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavadocParagraph false violation when <p> is inside of <div></div>
2 participants
@Aziz-755 @romani