Github, generate report for Indentation/all-examples-in-one

Failed to download or process the specified configuration(s).
Error details:

Please ensure you've used one of the following commands correctly:

• 'GitHub, generate report for <config_bundle_path>'
• 'GitHub, generate report by config from <file_path>'
• 'GitHub, generate report for configs in PR description'
  
  And check that all specified configs or files exist and are valid.
  
  Link: https://github.com/checkstyle/checkstyle/actions/runs/13756086125

Github, generate report for Indentation/all-examples-in-one

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fbfa4b19a114236c1adb04bbd96974cbabbf01d9_2025061020/reports/diff/index.html

@Zopsss , please do first review

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fbfa4b1_2025111135/reports/diff/index.html

first, we need to check regression on the project suggested here #14294 (comment)

report is ready #16515 (comment)

@Zopsss in the regression config, we need to specify the google_style config as this issue is related to google-style right?

Yes, find diff between current master branch's google_checks.xml config and your modified google_checks.xml config. Check the generated report, if false positives/negatives are introduced then report them here and try to fix them

Github, generate report

@Zopsss report generation exceeded 6 hours limit and got cancelled twice https://github.com/checkstyle/checkstyle/actions/runs/13871818479 ??

Sorry, even I'm seeing this error for the first time.

@romani can you check what's the issue here?

Github, generate report

Please do not run on whole Google style config, just use intendtation module from it, nothing else.

Github, generate report

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/13985147713

Github, generate report

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/13986614683

Error : Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project sample: Error generating maven-checkstyle-plugin:3.1.1:checkstyle report: Failed during checkstyle configuration: Exception was thrown while processing /home/runner/work/checkstyle/checkstyle/.ci-temp/contribution/checkstyle-tester/src/main/java/openjdk21/src/jdk.jlink/share/classes/module-info.java: IllegalStateException occurred while parsing file /home/runner/work/checkstyle/checkstyle/.ci-temp/contribution/checkstyle-tester/src/main/java/openjdk21/src/jdk.jlink/share/classes/module-info.java. 54:0: no viable alternative at input 'module': NoViableAltException -> [Help 1]

module-info.java

please use https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/my_check.xml but module should one one , attention to <!-- PLEASE CHANGE IT TO CHECK YOU ARE TESTING !!!! -->

<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
          "https://checkstyle.org/dtds/configuration_1_3.dtd">

<module name = "Checker">
    <property name="charset" value="UTF-8"/>

    <!-- do not change severity to 'error', as that will hide errors caused by exceptions -->
    <property name="severity" value="warning"/>

    <!-- haltOnException is required for exception fixes and reporting of all exceptions -->
    <property name="haltOnException" value="false"/>

    <!-- BeforeExecutionFileFilters is required for sources of java9 -->
    <module name="BeforeExecutionExclusionFileFilter">
        <property name="fileNamePattern" value="module\-info\.java$" />
    </module>

    <module name="TreeWalker">
         <!-- as we run on regression even on non-compiled files we need to skip exceptions on them -->
         <property name="skipFileOnJavaParseException" value="true"/>
         <property name="javaParseExceptionSeverity" value="ignore"/>

    
         
         <module name="Indentation">
             <property name="basicOffset" value="2"/>
             <property name="braceAdjustment" value="2"/>
             <property name="caseIndent" value="2"/>
             <property name="throwsIndent" value="4"/>
             <property name="lineWrappingIndentation" value="4"/>
             <property name="arrayInitIndent" value="2"/>
        </module>
         <!-- Suppression for block code until we find a way to detect them properly
         until https://github.com/checkstyle/checkstyle/issues/15769 -->
        <module name="SuppressionXpathSingleFilter">
           <property name="checks" value="Indentation"/>
           <property name="query" value="//SLIST[not(parent::CASE_GROUP)]/SLIST
                                   | //SLIST[not(parent::CASE_GROUP)]/SLIST/RCURLY"/>
        </module>

         <!-- suppress javadoc parsing errors, as we test Check not a parser -->
         <module name="SuppressionXpathSingleFilter">
            <property name="message" value="Javadoc comment at column \d+ has parse error"/>
         </module>
    </module>

</module>

@romani like this ?

Yes

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fbfa4b1_2025160926/reports/diff/index.html

diff is huge, please start copy all code from diff report to Input to have all distinct cases that we missed in Inputs.
Ideally we should have all in Inputs, and depend less on diff report.

report is weird. there are diffs in switch and case blocks. this report is based on google config and not every project uses it. so obviously there will be diffs.
only Hbase and camunda use google-style

we have already checked the regression using default indentation config #16515 (comment)

only Hbase and camunda use google-style

Please go through their diff and add missing examples to our inputs. We can ignore other projects.

Also if you're going to generate more regression reports then only include projects which uses google-style, other projects will not help us to find edge cases.

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fbfa4b1_2025031529/reports/diff/index.html

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fbfa4b1_2025035543/reports/diff/index.html

@Zopsss in camunda project, violations on switch expression are fixed in #16418. these diffs got removed that PR's regression report #16418 (comment)
As for the Hbase project, there are not any new violations. diff is due to change in violation message.

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1fb8_2025064429/reports/diff/index.html

like I said , there is no violation change in Hbase project, do I still need to add examples from it to our input ??

in camunda project, violations on switch expression are fixed in #16418. these diffs got removed that PR's regression report #16418 (comment)

Sorry I'm not able to understand why diff got removed. Were the violations in diff was false positives? And your PR fixed them?

As for the Hbase project, there are not any new violations. diff is due to change in violation message.

Can you point out the PR where the violation message was changed?

like I said , there is no violation change in Hbase project, do I still need to add examples from it to our input ??

Did we fixed some bug that's why the violation message was changed? Or is it something else?

If the diff doesn't have any false-postivie/negative and if you don't find an example which is not in our input files then you don't need to add any new example. We'll be good to go

@mohitsatr , please fix compilation problem https://app.circleci.com/pipelines/github/checkstyle/checkstyle/31749/workflows/70da813c-4d76-4d3a-a16f-5e33572194d9/jobs/850139

diffes in the Hbase project is mainly due to the way they are formatting for loops
indentation value of loop braces is same as indentation value of for keyword

for (...)
{
  ..
}  

this is how we expect it to be:

for (...)
  {
     ..
  }

now check is also giving correct violation

@Zopsss , please finish review

@romani please merge the PR