Skip to content

Issue #15763: fixed paragraph tag placement in some files #15737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2024
Merged

Issue #15763: fixed paragraph tag placement in some files #15737

merged 1 commit into from
Oct 13, 2024

Conversation

Zopsss
Copy link
Member

@Zopsss Zopsss commented Oct 4, 2024 •
edited by romani
Loading

part of #15763

@Zopsss
Copy link
Member Author

Zopsss commented Oct 4, 2024

not sure why build is failing

@romani
Copy link
Member

romani commented Oct 4, 2024 •
edited
Loading

I pushed commit.
https://github.com/checkstyle/checkstyle/pull/15737/files#diff-6d25a0aded27563391601304bd93333e6d7cad4b30497b8cc5796fe7453abe01L13

you need to change xdoc template file to make same removal of tags.
you need to run "mvn clean verify" on your local it will generate extra updates for sources that you need to put in your PR.

@romani romani mentioned this pull request Oct 10, 2024
Merged
@romani romani self-assigned this Oct 10, 2024
@romani
Copy link
Member

romani commented Oct 10, 2024

Please change commit to reference #15763

Lets proceed with updates.

If you have problems to understand how to upgrade, let's create PR for single Check update first, and then start updating more Checks.

@Zopsss Zopsss changed the title supplemental: fixed paragraph tag placement in some files Issue #15763: fixed paragraph tag placement in some files Oct 11, 2024
@romani
Copy link
Member

romani commented Oct 11, 2024

@Zopsss , please proceed with this issue , while you blocked by other

romani
romani approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge if CI pass.

thanks a lot for update !!!

@romani romani merged commit 5eca53c into checkstyle:master Oct 13, 2024
110 of 112 checks passed
@Zopsss Zopsss deleted the fix-paragraphs-1 branch October 13, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zopsss @romani