Issue #15045: Add LITERAL_WHEN as decision point in CyclomaticComplex… #15341
Conversation
| void testSwitch2(Object o) { // 1, function declaration | ||
| switch (o) { // 2 switch | ||
| case Integer i -> {} | ||
| case Point(int x, int y) when (x == 0 && y == 0) -> {} // 3, when - 4, && | ||
| case Point(int x, int y) when x == 0 -> {} // 5, when | ||
| default -> {} | ||
| } | ||
| } |
There was a problem hiding this comment.
I am not sure about it, but shouldn't it be more reasonable if we ignore everything inside the switch when switchBlockAsSingleDecisionPoint is true? because basically, we should treat switch as a single decision point so considering when and && as decision points and adding 1 to them is odd to me when this option is true
There was a problem hiding this comment.
Please add traditional switches in here with nested if statements to allow us to compare how this check handles them
There was a problem hiding this comment.
done, it got counted.
looks like we only ignore case when this option is true but anything else inside the switch will be counted
|
github, generate site |
|
github, generate report |
87d431a to
410ca20
Compare
410ca20 to
784590f
Compare
…ticComplexityCheck
784590f to
ecaace0
Compare
|
github, generate site |
closes #15045
Diff Regression config: https://gist.githubusercontent.com/mahfouz72/afd57aa6e51ca161b7927acd959e5211/raw/bdde1a4a901d1eca9e79c017dc8037fd989a020c/check.xml
Diff Regression patch config: https://gist.githubusercontent.com/mahfouz72/33967bf86e4a29cafa429771b0e95808/raw/6ec96ab6424c29e5c6ad0fb9d403cdda19054609/check_patch.xml