Skip to content

Issue #15007: Add input file for instanceof operator in OperatorWrap #15171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

Issue #15007: Add input file for instanceof operator in OperatorWrap #15171

merged 1 commit into from
Jun 30, 2024

Conversation

mahfouz72
Copy link
Member

closes #15007

@mahfouz72
Copy link
Member Author

github, generate site

@mahfouz72 mahfouz72 force-pushed the recordpattern-operatorwrap branch 3 times, most recently from 3cc2109 to 48d3832 Compare June 29, 2024 12:53
@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/3cc2109_2024125643/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/3cc2109_2024125643/checks/whitespace/operatorwrap.html#Description

@mahfouz72 mahfouz72 force-pushed the recordpattern-operatorwrap branch from 48d3832 to 1b16800 Compare June 29, 2024 13:40
nrmancuso
nrmancuso suggested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item:

@nrmancuso nrmancuso self-assigned this Jun 29, 2024
@mahfouz72 mahfouz72 force-pushed the recordpattern-operatorwrap branch 2 times, most recently from 95f9871 to ae9e6d5 Compare June 29, 2024 14:37
@nrmancuso nrmancuso assigned rnveach and unassigned nrmancuso Jun 29, 2024
rnveach
rnveach suggested changes Jun 30, 2024
View reviewed changes
src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/OperatorWrapCheck.java Outdated
@@ -31,7 +31,13 @@

/**
* <p>
* Checks the policy on how to wrap lines on operators.
* Checks the policy on how to wrap lines on
* <a href ="https://docs.oracle.com/javase/tutorial/java/nutsandbolts/opsummary.html">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space before =.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

...awl/tools/checkstyle/checks/whitespace/operatorwrap/InputOperatorWrapInstanceOfOperator.java
@@ -0,0 +1,93 @@
/*
OperatorWrap
option = (default)nl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate file with other option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mahfouz72 mahfouz72 force-pushed the recordpattern-operatorwrap branch from ae9e6d5 to ca342c3 Compare June 30, 2024 09:45
@rnveach rnveach merged commit ab017ae into checkstyle:master Jun 30, 2024
@mahfouz72 mahfouz72 deleted the recordpattern-operatorwrap branch May 9, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@rnveach rnveach rnveach approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rnveach rnveach

Labels
None yet
Projects
No open projects
Java 21 Language Features Support
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Check Support for Java 21 Record Pattern Syntax: OperatorWrap
3 participants
@mahfouz72 @rnveach @nrmancuso