-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Issue #14966: Update MethodParmPad to support record patterns #15168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14966: Update MethodParmPad to support record patterns #15168
Conversation
a138bfd
to
a41bb9e
Compare
github, generate site |
github, generate report |
edit by @nrmancuso : this report is invalid |
github, generate report |
@mahfouz72 please provide an analysis of the reports, it is not clear to me why we lost violations on |
Please consider the last report (always) , not the first one. In the first one we lost violation on |
Not sure if this is a good policy, especially when we are generating several reports purposefully. If we have some bad/ invalid report, please leave a comment or edit your existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheck.java
Outdated
Show resolved
Hide resolved
...tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadCheckRecordPattern.java
Show resolved
Hide resolved
...tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadCheckRecordPattern.java
Show resolved
Hide resolved
...tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadCheckRecordPattern.java
Show resolved
Hide resolved
f35272e
to
1494ddc
Compare
1494ddc
to
35a8e4c
Compare
github, generate report |
Report generation failed on phase "make_report", |
I didn't extend the projects list. This is the same list with almost same config just changed value of properties |
If regression prints too many violations then it will run out of memory. That is most likely the case here. If you ran this before with no issues (same config/project), then it could be a new machine with less memory. I would remove the project(s) that cause the issues. |
Yes, I just change the |
github, generate report |
closes #14966 :
Diff Regression config: https://gist.githubusercontent.com/mahfouz72/afd57aa6e51ca161b7927acd959e5211/raw/b2b2571b42b8fa0f5e95ea546e9fa16e98948980/check.xml
Diff Regression patch config: https://gist.githubusercontent.com/mahfouz72/33967bf86e4a29cafa429771b0e95808/raw/761163c3fb766f95d7303e07c60ef178013be96e/check_patch.xml
Diff Regression projects: https://gist.githubusercontent.com/mahfouz72/a3d0af030c8f5efd0d8a39f2c14750bc/raw/a3424ad9b6f722e5de1a927e3d85e383101b2b93/projects-to-test-on.properties