Skip to content

Conversation

@mahfouz72 mahfouz72 force-pushed the methodparampad-recordpattern branch from a138bfd to a41bb9e Compare June 29, 2024 01:14
@mahfouz72
Copy link
Member Author

github, generate site

@mahfouz72
Copy link
Member Author

github, generate report

Copy link
Contributor

github-actions bot commented Jun 29, 2024

@mahfouz72
Copy link
Member Author

github, generate report

Copy link
Contributor

@nrmancuso
Copy link
Contributor

@mahfouz72 please provide an analysis of the reports, it is not clear to me why we lost violations on this(); in a few places.

@nrmancuso nrmancuso self-assigned this Jun 29, 2024
@nrmancuso nrmancuso requested review from nrmancuso and rnveach June 29, 2024 13:29
@mahfouz72
Copy link
Member Author

please provide an analysis of the reports, it is not clear to me why we lost violations on this(); in a few places.

Please consider the last report (always) , not the first one. In the first one we lost violation on this () because I missed the token in the config

@nrmancuso
Copy link
Contributor

Please consider the last report (always) ,

Not sure if this is a good policy, especially when we are generating several reports purposefully. If we have some bad/ invalid report, please leave a comment or edit your existing Github, generate report comment to let us know that there was some issue or whatever. Especially if I do not see any commits pushed, I consider any report that is here to be something I should review.

Copy link
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nrmancuso nrmancuso assigned rnveach and unassigned nrmancuso Jun 29, 2024
@mahfouz72 mahfouz72 force-pushed the methodparampad-recordpattern branch 5 times, most recently from f35272e to 1494ddc Compare June 30, 2024 12:29
@mahfouz72 mahfouz72 force-pushed the methodparampad-recordpattern branch from 1494ddc to 35a8e4c Compare June 30, 2024 13:56
@mahfouz72
Copy link
Member Author

github, generate report

Copy link
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9732813470

@mahfouz72
Copy link
Member Author

mahfouz72 commented Jun 30, 2024

Error:  Java heap space -> [Help 1]
java.lang.OutOfMemoryError: Java heap space
    at sun.nio.cs.StreamEncoder.write (StreamEncoder.java:133)

I didn't extend the projects list. This is the same list with almost same config just changed value of properties

@rnveach
Copy link
Contributor

rnveach commented Jun 30, 2024

If regression prints too many violations then it will run out of memory. That is most likely the case here. If you ran this before with no issues (same config/project), then it could be a new machine with less memory. I would remove the project(s) that cause the issues.

@mahfouz72
Copy link
Member Author

mahfouz72 commented Jun 30, 2024

Yes, I just change the option to space this definitely produces a huge amount of violation in all projects.
it was no space before:

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a41bb9e_2024112416/reports/diff/index.html

@mahfouz72
Copy link
Member Author

github, generate report

Copy link
Contributor

@rnveach rnveach merged commit 7f83027 into checkstyle:master Jul 1, 2024
@mahfouz72 mahfouz72 deleted the methodparampad-recordpattern branch May 9, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add Check Support for Java 21 Record Pattern : MethodParamPad
3 participants