Skip to content

Add Check Support for Java 21 Record Pattern Syntax: NoWhitespaceAfter #15009

@mahfouz72

Description

@mahfouz72

child of #14890
I have read check documentation:https://checkstyle.org/checks/whitespace/nowhitespaceafter.html#NoWhitespaceAfter
I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run
I have executed the cli and showed it below, as cli describes the problem better than 1,000 words

PS D:\CS\test> cat src/Test2.java                                                
record ColoredPoint(int p, int x, String c) { }
record Rectangle(ColoredPoint upperLeft, ColoredPoint lowerRight) { }
record Pair<T>(T x, T y) {
    }
public class Test2 {
    void test(Object obj) {
        synchronized (this) {} // violation
        if (obj instanceof Rectangle  (ColoredPoint record,ColoredPoint yield)) {    // expceted violation
        }
    }

}
PS D:\CS\test> cat config.xml                                                    
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
        "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
        "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">
    <property name="charset" value="UTF-8"/>
    <module name="TreeWalker">
        <module name="NoWhitespaceAfter">
            <property name="tokens" value="LITERAL_SYNCHRONIZED"/>
        </module>

    </module>
</module>
PS D:\CS\test> java  -jar checkstyle-10.17.0-all.jar -c config.xml src/Test2.java
Starting audit...
[ERROR] D:\CS\test\src\Test2.java:7:9: 'synchronized' is followed by whitespace. [NoWhitespaceAfter]
Audit done.
Checkstyle ends with 1 errors.
PS D:\CS\test> 

Describe what you expect in detail.

I want a violation on record pattern. we have this issue to have violation for the same example. do you think both checks should violate this example?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions