-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Closed
Copy link
Description
child of #14890
I have read check documentation:https://checkstyle.org/checks/naming/illegalidentifiername.html#IllegalIdentifierName
I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run
I have executed the cli and showed it below, as cli describes the problem better than 1,000 words
PS D:\CS\test> cat src/Test2.java
record ColoredPoint(int p, int x, String c) { }
record Rectangle(ColoredPoint upperLeft, ColoredPoint lowerRight) { }
public class Test2 {
void test(Object obj) {
if (!(obj instanceof Rectangle(ColoredPoint record,ColoredPoint yield))) { // 2 violations
}
}
}
PS D:\CS\test> cat config.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<module name="Checker">
<property name="charset" value="UTF-8"/>
<module name="TreeWalker">
<module name="IllegalIdentifierNameCheck">
</module>
</module>
</module>
PS D:\CS\test> java -jar checkstyle-10.17.0-all.jar -c config.xml src/Test2.java
Starting audit...
[ERROR] D:\CS\test\src\Test2.java:5:53: Name 'record' must match pattern '(?i)^(?!(record|yield|var|permits|sealed|_)$).+$'. [IllegalIdentifierName]
[ERROR] D:\CS\test\src\Test2.java:5:73: Name 'yield' must match pattern '(?i)^(?!(record|yield|var|permits|sealed|_)$).+$'. [IllegalIdentifierName]
Audit done.
Checkstyle ends with 2 errors.
PS D:\CS\test>
Describe what you expect in detail.
input file