Skip to content

Escape sequences in TextBlock, IllegalTokenText module should violate them for Google style #14291

New issue
New issue
Closed
Closed
Escape sequences in TextBlock, IllegalTokenText module should violate them for Google style#14291
Labels
approvedbuggoogle style
Milestone
11.0.0
@nrmancuso

Description

@nrmancuso
nrmancuso
opened on Jan 18, 2024

Noticed at #13991 (comment)

checkstyle/src/main/resources/google_checks.xml

Lines 53 to 59 in 2534302

<module name="IllegalTokenText">
<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
<property name="format"
value="\\u00(09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
<property name="message"
value="Consider using special escape sequence instead of octal value or Unicode escaped value."/>
</module>

We have a few other tokens that have text that should be checked now, such as TEXT_BLOCK_CONTENT and STRING_TEMPLATE_CONTENT that should be added to the configuration linked above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    approvedbuggoogle style

    Type

    No type

    Projects

    Polishing Google Style implementation

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions