feat: better handle api #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `default-api` in the configuration file - cache stores the API as well - and displays it in the list - improved resolution of api+model/aliases closes #300
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit handling of API endpoints alongside models, persisting the API in the cache and configuration, and improves resolution logic to match models and aliases per-API.
- Introduce
default-apiin config and load it intoConfig.API - Migrate DB to add an
apicolumn and update allSavecalls - Add
resolveModelhelper to pair an API with its model (including alias support)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mods.go | Load and propagate API in state, replace inline model lookup with resolveModel, extend cacheDetails to include API |
| db.go | Auto-migrate new api column, update Save to store API |
| main.go | Display API in conversation list and pass API to DB |
| config.go | Add default-api field, update help text |
| config_template.yml | Add default-api to template |
| mods_test.go | Update tests to include API parameter in Save |
| db_test.go | Update DB tests to cover new api column |
Comments suppressed due to low confidence (1)
mods.go:726
- The new resolveModel function contains non-trivial logic for alias matching and error handling, but there are no dedicated unit tests for it. Consider adding tests covering valid resolutions, alias handling, and each error branch.
func (m *Mods) resolveModel(cfg *Config) (API, Model, error) {
aymanbagabas
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default-apiin the configuration filethis should give more control to which model/api to use
closes #300