fix: disable topp, topk, temp, if values < 0 #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since even if left out of the config/flags it will be 0, and zero is valid, we can disable these options by setting them to a negative number.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the completion command to disable temperature, top_p, and top_k parameters when set to negative values by introducing a helper function that returns nil for negatives.
- Replace direct pointers to cfg.Temperature/TopP/TopK with
ptrOrNilcalls - Add a generic
ptrOrNilhelper that returns nil when the value is negative
Comments suppressed due to low confidence (1)
mods.go:758
- Add unit tests for
ptrOrNilto verify that it returnsnilfor negative values and a valid pointer for zero and positive values, ensuring the disable logic behaves as expected.
func ptrOrNil[T number](t T) *T {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since even if left out of the config/flags it will be 0, and zero is valid, we can disable these options by setting them to a negative number.
closes #480