Fix Perplexity API Role Compatibility (Issue #448) #454
+8
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
reviewed
Mar 5, 2025
stream.go
Outdated
Comment on lines
25
to
36
| messages := m.messages | ||
| if mod.Name == "o1-preview" || mod.Name == "o1-mini" { | ||
| messages = []openai.ChatCompletionMessage{} | ||
| for _, message := range m.messages { | ||
| if message.Role == openai.ChatMessageRoleSystem { | ||
| messages = append(messages, openai.ChatCompletionMessage{ | ||
| Role: openai.ChatMessageRoleUser, | ||
| Content: message.Content, | ||
| }) | ||
| } else { | ||
| messages = append(messages, message) | ||
| } |
There was a problem hiding this comment.
could probably simplify this to something like:
if mod.Name == "o1-preview" || mod.Name == "o1-mini" {
for i := range m.messages {
if message.Role != openai.ChatMessageRoleSystem {
continue
}
m.messages[i].Role = openai.ChatMessageRoleUser
}
}There was a problem hiding this comment.
yeah you're right, simplified it.
caarlos0
reviewed
Mar 5, 2025
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Perplexity API Role Compatibility (Issue #448)
This fix maintains compatibility with legacy o1 models while solving the Perplexity error.
The Problem
A previous update (commit e5e4bdd) added support for o1-preview and o1-mini models by converting system messages to user messages. However, this breaks Perplexity models because their API doesn't allow multiple consecutive messages with the same role.
How to See the Issue
Try this command and you'll see an error:
Solution
createOpenAIStream (stream.go)Note
The system message remapping is not needed for these models, which handle system messages correctly without modification: