fix: improve completion cmd handling #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way it works today, its not possible to install the completions automatically on Nix, as the build needs to be pure. This is kinda hacky, but I think it'll work: we only allow the completion cmd to run if there is good evidence that it is a completion command, and not a prompt that happens to start with completion. refs #287
aymanbagabas
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way it works today, its not possible to install the completions
automatically on Nix, as the build needs to be pure.
This is kinda hacky, but I think it'll work: we only allow the
completion cmd to run if there is good evidence that it is a completion
command, and not a prompt that happens to start with completion.
refs #287