Skip to content

feat: cobra, shell completions, perf and ui improvements #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Sep 1, 2023
Merged

feat: cobra, shell completions, perf and ui improvements #112

merged 32 commits into from
Sep 1, 2023

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Aug 29, 2023 •
edited by caarlos0
Loading

  • Use Cobra
  • Clean up
  • Refactor
  • shell completions
  • improve performance a bit
  • some ui style improvements

@aymanbagabas
refactor: use cobra for flags
3253836 
- Use Cobra
- Clean up
- Refactor
@aymanbagabas aymanbagabas requested review from toby and caarlos0 August 29, 2023 17:40
@aymanbagabas aymanbagabas marked this pull request as ready for review August 29, 2023 17:40
@aymanbagabas aymanbagabas changed the title refactor: use cobra for flags (wip) refactor: use cobra for flags Aug 29, 2023
caarlos0 added 13 commits August 30, 2023 13:02
@caarlos0
fix: db path
a0a5610
@caarlos0
feat: completions
137155f
@caarlos0
chore: cleanup
923c3b3
@caarlos0
chore: cleanup
02f9c3e
@caarlos0
fix: tests
e4f52f1
@caarlos0
test: db.Completions
84ed279
@caarlos0
fix: improvements
64d12d3
@caarlos0
fix: config
40b3365
@caarlos0
test: fix broken test
6ea6b84 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: env, gitignore
4ee6c38
@caarlos0
fix: no need to wrap in an error
a7fefe6 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: mods with no args
36e2f1a 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: --list should print list to stdout (#113)
2660b79 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member

closes #111

@caarlos0
fix: improve error handling (#114)
82a634e 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: styles & stderr
f61b61e 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
aymanbagabas
aymanbagabas commented Aug 30, 2023
View reviewed changes
caarlos0 and others added 5 commits August 30, 2023 19:19
@caarlos0
fix: version
efb6f86 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: remove unused examples
126c58b
@aymanbagabas
fix: hide completion and help commands
9658602
@aymanbagabas
fix: error handling
e45b5aa 
- Fix modsError
- Error when continuing without a prompt
@aymanbagabas
fix: mark flags as mutually exclusive
303f934
caarlos0
caarlos0 reviewed Aug 30, 2023
View reviewed changes
caarlos0
caarlos0 reviewed Aug 30, 2023
View reviewed changes
aymanbagabas
aymanbagabas commented Aug 31, 2023
View reviewed changes
@caarlos0 caarlos0 changed the title (wip) refactor: use cobra for flags feat: cobra, shell completions, perf and ui improvements Aug 31, 2023
@caarlos0 caarlos0 self-assigned this Aug 31, 2023
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 31, 2023
@caarlos0 caarlos0 merged commit 17a19d4 into main Sep 1, 2023
@caarlos0 caarlos0 deleted the cobraaa branch September 1, 2023 01:42
@peterldowns peterldowns mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 left review comments

@toby toby Awaiting requested review from toby

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @caarlos0