fix: support custom slog levels #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 80.92% 80.48% -0.44%
==========================================
Files 11 11
Lines 739 656 -83
==========================================
- Hits 598 528 -70
+ Misses 126 112 -14
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. |
aymanbagabas
approved these changes
Apr 22, 2024
|
Thank you @lvlcn-t! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #116
Changes
I've removed the
fromSlogLevelmap and type casting toint32/Levelinstead.For more information look at the commits.
Tests done
I've provided two unit tests with custom slog levels. If you want me to write additional test cases, feel free to ask for them.