feat: support grouped commands and fix flag style #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- supports grouped commands (alternative impl of #33) - fixes the help flag styles Co-authored-by: David Napier <dnapier@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for grouped commands in the CLI and improves the formatting of help flag styles. Key changes include:
- Adjusted indentation and spacing in various help golden files.
- Addition of group handling (evalGroups and renderGroup functions) in help.go.
- Updated tests and examples to reflect the new grouped command functionality.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/TestSetup/*/help.golden | Updated flag spacing and indentation |
| testdata/TestSetup/with_command_groups/* | Added new grouped command sections |
| help.go | Introduced grouped commands rendering and refactored evalCmds/evalGroups |
| fang_test.go | Added tests for command groups |
| example/main.go | Updated example to include command groups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32
closes #33