fix: better handle pipes, single quotes, stdin (-) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the handling of pipe characters (|) and standard input (-) in command examples. Key changes include:
- Updating the indentation logic in help.go to account for pipe characters.
- Modifying quoted string and flag detection to support both double and single quotes.
- Adding new pipe examples in testdata, fang_test.go, and example/main.go to verify the behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testdata/TestSetup/with_examples/help.golden | Added examples showcasing pipe usage and stdin handling. |
| help.go | Updated logic for indent determination and argument styling. |
| fang_test.go | Included new test examples for pipe and stdin scenarios. |
| example/main.go | Provided updated inline examples for pipe-based command usage. |
Comments suppressed due to low confidence (2)
help.go:263
- Verify that the switch cases for single-character '-' and '|' are intentional and do not conflict with standard flag processing for similar symbols.
if len(arg) == 1 {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipes
|, stdin-, and single quotes were not being handled properly.this fixes it.