fix: check bg color on stdout instead of stderr #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we do use stdout to print stuff.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic for determining the terminal's background color by checking stdout instead of stderr.
- Update the call to lipgloss.HasDarkBackground to use os.Stdout, ensuring theme colors match the actual output stream.
Comments suppressed due to low confidence (1)
theme.go:95
- [nitpick] Using stdout to assess the terminal's background is a good update; please confirm that using os.Stdin as the first argument is intentional and aligns with your overall terminal input/output handling.
isDark = lipgloss.HasDarkBackground(os.Stdin, os.Stdout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we do use stdout to print stuff.