feat: support having a custom error handler #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a custom error handler to allow users to extract more information from errors before printing or to print them differently.
- Introduces an ErrorHandler type and its default implementation (DefaultErrorHandler) in fang.go.
- Adds a WithErrorHandler option to override the default behavior.
- Updates the help output and adds a test in fang_test.go to validate the custom error handler functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| testdata/TestSetup/custom_error_handler.golden | Adds a golden file with the expected custom error message output |
| help.go | Replaces the internal writeError with the new DefaultErrorHandler function |
| fang_test.go | Introduces a test case that verifies custom error handler functionality |
| fang.go | Defines the ErrorHandler type, a default handler, and the WithErrorHandler option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the cases you want to extract more information from the error before printing it, or just print it differently.