fix: improve width calculations #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how codeblock widths are calculated and truncates long example lines on narrow terminals.
- Simplify width computation by unifying usage and example widths with padding.
- Add
ansi.Truncateto clamp examples that exceed available width. - Shorten example command’s
Shortdescription.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| help.go | Unified width logic, import ansi, truncate long examples |
| example/main.go | Updated Short description for the throw command |
Comments suppressed due to low confidence (3)
help.go:58
- New truncation logic is introduced here; consider adding unit tests to verify that long examples are correctly truncated when exceeding
cw.
examples[i] = ansi.Truncate(example, cw, "…")
help.go:61
- The
stringspackage is used here but not imported; addimport "strings"to avoid a compile error.
_, _ = fmt.Fprintln(w, styles.Codeblock.Base.Render(strings.Join(examples, "\n")))
help.go:68
- The
leftPaddingvariable is declared but never used; consider removing it to keep the code clean.
leftPadding := 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, if the screen is too narrow, use ansi truncate to prevent breaking things.