Skip to content

Detect timeout error and apply default option #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Detect timeout error and apply default option #888

merged 1 commit into from
Apr 11, 2025

Conversation

mikybars
Copy link
Contributor

@mikybars mikybars commented Apr 11, 2025 •
edited
Loading

This is a quick fix to prove the point made here #876 (comment) about the timeout condition not being handled properly at the moment

@mikybars mikybars requested a review from a team as a code owner April 11, 2025 10:50
@mikybars mikybars requested review from raphamorim and removed request for a team April 11, 2025 10:50
andreynering
andreynering approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. Thank you!

@andreynering andreynering merged commit e292bbf into charmbracelet:main Apr 11, 2025
5 of 7 checks passed
@acamatcisco acamatcisco mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreynering andreynering andreynering approved these changes

@raphamorim raphamorim Awaiting requested review from raphamorim raphamorim is a code owner automatically assigned from charmbracelet/everyone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikybars @andreynering