feat: show indicator on help keybindings (opt-in) #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
approved these changes
Feb 4, 2025
|
Excellent work ❤️! Why not extend it for more cases instead of just (replace seq with your use-case)
I'd still like to know how many rows I have available and which row I am in. I think this would be useful for more use-cases, like fzf does. Love you guys :) |
|
yeah that probably makes sense! created a discussion for it: #869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
This allow table display to be configurable and show item quantity on helper. It can be disabled by
hideIndicator.Before
After