Skip to content

fix: spin when not a tty #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: spin when not a tty #813

merged 2 commits into from
Jan 21, 2025

Conversation

caarlos0
Copy link
Member

fixes #812
refs #763

@caarlos0 caarlos0 self-assigned this Jan 21, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner January 21, 2025 19:18
@caarlos0 caarlos0 requested review from csandeep and removed request for a team January 21, 2025 19:18
@caarlos0 caarlos0 mentioned this pull request Jan 21, 2025
Closed
bashbunni
bashbunni approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@bashbunni bashbunni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this affect tests?

Edit: heh it's gum, not huh. Looks great for Gum. Going to check the examples are working as expected on my end

@caarlos0 caarlos0 mentioned this pull request Jan 21, 2025
Closed
@caarlos0 caarlos0 merged commit 05c4bb9 into main Jan 21, 2025
14 checks passed
@caarlos0 caarlos0 deleted the spin-ttyr branch January 21, 2025 22:37
@bashbunni bashbunni added this to the v0.15.1 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbunni bashbunni bashbunni approved these changes

@csandeep csandeep Awaiting requested review from csandeep csandeep is a code owner automatically assigned from charmbracelet/everyone

Assignees

@caarlos0 caarlos0

Labels
None yet
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @bashbunni