Skip to content

fix(write): max height, max chars #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(write): max height, max chars #753

merged 1 commit into from
Dec 9, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 9, 2024

  • it makes no sense to me to have 400 as limit?
  • textarea default max height is 99, we should probably set it to 0

closes #666

@caarlos0
fix(write): max height, max chars
b15b8d1 
- it makes no sense to me to have 400 as limit?
- textarea default max height is 99, we should probably set it to 0

closes #666
@caarlos0 caarlos0 marked this pull request as ready for review December 9, 2024 20:41
meowgorithm
meowgorithm approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@meowgorithm meowgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fwiw, in v2 we're removing these baked-in limits in textarea itself.

@caarlos0 caarlos0 merged commit 01892a0 into main Dec 9, 2024
14 checks passed
@caarlos0 caarlos0 deleted the write-height branch December 9, 2024 23:53
@bashbunni bashbunni added this to the v0.15.0 milestone Jan 12, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Gum write limited to 99 lines despite --char-limit 0
3 participants
@caarlos0 @meowgorithm @bashbunni